Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/arm64/full-codegen-arm64.cc

Issue 995013005: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix hardcoded constant. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/full-codegen-arm64.cc
diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc
index 9731f1b62640f12718022319d4e01384d2383fd4..a8f5ed554293af985db1328de7ee5f3e87b7d21f 100644
--- a/src/arm64/full-codegen-arm64.cc
+++ b/src/arm64/full-codegen-arm64.cc
@@ -5348,12 +5348,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ SmiTag(x11);
__ Push(x10, x11);
-
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ Mov(x10, pending_message_script);
- __ Ldr(x10, MemOperand(x10));
- __ Push(x10);
}
@@ -5362,23 +5356,18 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(x10));
// Restore pending message from stack.
- __ Pop(x10, x11, x12);
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ Mov(x13, pending_message_script);
- __ Str(x10, MemOperand(x13));
-
- __ SmiUntag(x11);
+ __ Pop(x10, x11);
+ __ SmiUntag(x10);
ExternalReference has_pending_message =
ExternalReference::address_of_has_pending_message(isolate());
__ Mov(x13, has_pending_message);
STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
- __ Strb(x11, MemOperand(x13));
+ __ Strb(x10, MemOperand(x13));
ExternalReference pending_message_obj =
ExternalReference::address_of_pending_message_obj(isolate());
__ Mov(x13, pending_message_obj);
- __ Str(x12, MemOperand(x13));
+ __ Str(x11, MemOperand(x13));
// Restore result register and cooked return address from the stack.
__ Pop(x10, result_register());
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698