Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 995013005: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix hardcoded constant. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/serialize.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5254 matching lines...) Expand 10 before | Expand all | Expand 10 after
5265 ExternalReference pending_message_obj = 5265 ExternalReference pending_message_obj =
5266 ExternalReference::address_of_pending_message_obj(isolate()); 5266 ExternalReference::address_of_pending_message_obj(isolate());
5267 __ Load(rdx, pending_message_obj); 5267 __ Load(rdx, pending_message_obj);
5268 __ Push(rdx); 5268 __ Push(rdx);
5269 5269
5270 ExternalReference has_pending_message = 5270 ExternalReference has_pending_message =
5271 ExternalReference::address_of_has_pending_message(isolate()); 5271 ExternalReference::address_of_has_pending_message(isolate());
5272 __ Load(rdx, has_pending_message); 5272 __ Load(rdx, has_pending_message);
5273 __ Integer32ToSmi(rdx, rdx); 5273 __ Integer32ToSmi(rdx, rdx);
5274 __ Push(rdx); 5274 __ Push(rdx);
5275
5276 ExternalReference pending_message_script =
5277 ExternalReference::address_of_pending_message_script(isolate());
5278 __ Load(rdx, pending_message_script);
5279 __ Push(rdx);
5280 } 5275 }
5281 5276
5282 5277
5283 void FullCodeGenerator::ExitFinallyBlock() { 5278 void FullCodeGenerator::ExitFinallyBlock() {
5284 DCHECK(!result_register().is(rdx)); 5279 DCHECK(!result_register().is(rdx));
5285 DCHECK(!result_register().is(rcx)); 5280 DCHECK(!result_register().is(rcx));
5286 // Restore pending message from stack. 5281 // Restore pending message from stack.
5287 __ Pop(rdx); 5282 __ Pop(rdx);
5288 ExternalReference pending_message_script =
5289 ExternalReference::address_of_pending_message_script(isolate());
5290 __ Store(pending_message_script, rdx);
5291
5292 __ Pop(rdx);
5293 __ SmiToInteger32(rdx, rdx); 5283 __ SmiToInteger32(rdx, rdx);
5294 ExternalReference has_pending_message = 5284 ExternalReference has_pending_message =
5295 ExternalReference::address_of_has_pending_message(isolate()); 5285 ExternalReference::address_of_has_pending_message(isolate());
5296 __ Store(has_pending_message, rdx); 5286 __ Store(has_pending_message, rdx);
5297 5287
5298 __ Pop(rdx); 5288 __ Pop(rdx);
5299 ExternalReference pending_message_obj = 5289 ExternalReference pending_message_obj =
5300 ExternalReference::address_of_pending_message_obj(isolate()); 5290 ExternalReference::address_of_pending_message_obj(isolate());
5301 __ Store(pending_message_obj, rdx); 5291 __ Store(pending_message_obj, rdx);
5302 5292
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
5416 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5406 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5417 Assembler::target_address_at(call_target_address, 5407 Assembler::target_address_at(call_target_address,
5418 unoptimized_code)); 5408 unoptimized_code));
5419 return OSR_AFTER_STACK_CHECK; 5409 return OSR_AFTER_STACK_CHECK;
5420 } 5410 }
5421 5411
5422 5412
5423 } } // namespace v8::internal 5413 } } // namespace v8::internal
5424 5414
5425 #endif // V8_TARGET_ARCH_X64 5415 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/serialize.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698