Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 991533003: Handle more <length> properties in animation (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handle more <length> properties in css/web animation. This change adds the following properties to the LengthStyleInterpolation codepath: 'cx', 'cy', 'r', 'rx', 'ry' and 'stroke-dashoffset' BUG=400725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191762

Patch Set 1 #

Patch Set 2 : stroke-dashoffset setter exists + fixups + add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -53 lines) Patch
A + LayoutTests/animations/interpolation/svg-cx-interpolation.html View 1 5 chunks +18 lines, -6 lines 0 comments Download
A LayoutTests/animations/interpolation/svg-cx-interpolation-expected.txt View 1 1 chunk +60 lines, -0 lines 0 comments Download
A + LayoutTests/animations/interpolation/svg-cy-interpolation.html View 1 5 chunks +18 lines, -6 lines 0 comments Download
A LayoutTests/animations/interpolation/svg-cy-interpolation-expected.txt View 1 1 chunk +60 lines, -0 lines 0 comments Download
A + LayoutTests/animations/interpolation/svg-r-interpolation.html View 1 7 chunks +22 lines, -10 lines 0 comments Download
A LayoutTests/animations/interpolation/svg-r-interpolation-expected.txt View 1 1 chunk +76 lines, -0 lines 0 comments Download
A + LayoutTests/animations/interpolation/svg-rx-interpolation.html View 1 7 chunks +22 lines, -10 lines 0 comments Download
A LayoutTests/animations/interpolation/svg-rx-interpolation-expected.txt View 1 1 chunk +76 lines, -0 lines 0 comments Download
A + LayoutTests/animations/interpolation/svg-ry-interpolation.html View 1 7 chunks +22 lines, -10 lines 0 comments Download
A LayoutTests/animations/interpolation/svg-ry-interpolation-expected.txt View 1 1 chunk +76 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-dashoffset-interpolation.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-dashoffset-interpolation-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 1 3 chunks +16 lines, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-10 11:29:21 UTC) #2
Eric Willigers
lgtm
5 years, 9 months ago (2015-03-10 11:46:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991533003/1
5 years, 9 months ago (2015-03-10 11:46:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28640)
5 years, 9 months ago (2015-03-10 12:02:16 UTC) #7
dstockwell
What's the purpose of this change?
5 years, 9 months ago (2015-03-10 21:20:30 UTC) #8
alancutter (OOO until 2018)
This change should be adding tests. See LayoutTests/animations/interpolation/svg-stroke-dashoffset-interpolation.html for an example of a CSS/Web Animation ...
5 years, 9 months ago (2015-03-10 22:00:33 UTC) #10
Erik Dahlström (inactive)
On 2015/03/10 21:20:30, dstockwell wrote: > What's the purpose of this change? In this particular ...
5 years, 9 months ago (2015-03-11 12:54:11 UTC) #11
Erik Dahlström (inactive)
On 2015/03/10 22:00:33, alancutter wrote: > This change should be adding tests. > See > ...
5 years, 9 months ago (2015-03-11 12:58:32 UTC) #12
alancutter (OOO until 2018)
lgtm
5 years, 9 months ago (2015-03-11 23:06:57 UTC) #13
dstockwell
On 2015/03/11 at 12:54:11, ed wrote: > On 2015/03/10 21:20:30, dstockwell wrote: > > What's ...
5 years, 9 months ago (2015-03-11 23:11:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991533003/20001
5 years, 9 months ago (2015-03-12 08:15:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28823)
5 years, 9 months ago (2015-03-12 08:32:22 UTC) #19
dstockwell
lgtm
5 years, 9 months ago (2015-03-12 08:45:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991533003/20001
5 years, 9 months ago (2015-03-12 08:45:38 UTC) #22
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 08:48:58 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191762

Powered by Google App Engine
This is Rietveld 408576698