Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 991533003: Handle more <length> properties in animation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: stroke-dashoffset setter exists + fixups + add tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/StringKeyframe.cpp
diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp
index fef14e36edef7b4f015cd1302456206aa0306ef6..e0c80a8e56832fe62bd7a9cf48142617f7450161 100644
--- a/Source/core/animation/StringKeyframe.cpp
+++ b/Source/core/animation/StringKeyframe.cpp
@@ -170,6 +170,9 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyPaddingRight:
case CSSPropertyPaddingTop:
case CSSPropertyPerspective:
+ case CSSPropertyR:
+ case CSSPropertyRx:
+ case CSSPropertyRy:
case CSSPropertyShapeMargin:
case CSSPropertyStrokeWidth:
case CSSPropertyWebkitBorderHorizontalSpacing:
@@ -181,6 +184,8 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
// Fall through
case CSSPropertyBaselineShift:
case CSSPropertyBottom:
+ case CSSPropertyCx:
+ case CSSPropertyCy:
case CSSPropertyLeft:
case CSSPropertyLetterSpacing:
case CSSPropertyMarginBottom:
@@ -194,6 +199,8 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::
case CSSPropertyVerticalAlign:
case CSSPropertyWordSpacing:
case CSSPropertyWebkitColumnRuleWidth:
+ case CSSPropertyX:
+ case CSSPropertyY:
if (LengthStyleInterpolation::canCreateFrom(*fromCSSValue, property) && LengthStyleInterpolation::canCreateFrom(*toCSSValue, property))
return LengthStyleInterpolation::create(*fromCSSValue, *toCSSValue, property, range);
« no previous file with comments | « Source/core/animation/LengthStyleInterpolation.cpp ('k') | Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698