Source/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 991533003: Handle more <length> properties in animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 991533003: Handle more <length> properties in animation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: stroke-dashoffset setter exists + fixups + add tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/Source/core/css/resolver/AnimatedStyleBuilder.cpp b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

index 3fc437190bc2ca47b6c26584cb487f544725ef29..130d98546225839bf1a60a57a296fc1abffec1d1 100644

--- a/Source/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -640,13 +640,13 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property, StyleResolverSt

style->setY(animatableValueToLength(value, state));

return;

case CSSPropertyR:

- style->setR(animatableValueToLength(value, state));

+ style->setR(animatableValueToLength(value, state, ValueRangeNonNegative));

return;

case CSSPropertyRx:

- style->setRx(animatableValueToLength(value, state));

+ style->setRx(animatableValueToLength(value, state, ValueRangeNonNegative));

return;

case CSSPropertyRy:

- style->setRy(animatableValueToLength(value, state));

+ style->setRy(animatableValueToLength(value, state, ValueRangeNonNegative));

return;

default:

« no previous file with comments | « Source/core/animation/StringKeyframe.cpp ('k') | Source/core/layout/style/LayoutStyle.h » ('j') | no next file with comments »