Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: Source/core/animation/LengthStyleInterpolation.cpp

Issue 991533003: Handle more <length> properties in animation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: stroke-dashoffset setter exists + fixups + add tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/LengthStyleInterpolation.cpp
diff --git a/Source/core/animation/LengthStyleInterpolation.cpp b/Source/core/animation/LengthStyleInterpolation.cpp
index 921beb6517c6ff6ad1b688bc1da9590cb37f7103..0bca0dc94e2a0056c7ba3e1dcfe8a5a114130632 100644
--- a/Source/core/animation/LengthStyleInterpolation.cpp
+++ b/Source/core/animation/LengthStyleInterpolation.cpp
@@ -127,6 +127,10 @@ LengthStyleInterpolation::LengthSetter LengthStyleInterpolation::lengthSetterFor
switch (property) {
case CSSPropertyBottom:
return &LayoutStyle::setBottom;
+ case CSSPropertyCx:
+ return &LayoutStyle::setCx;
+ case CSSPropertyCy:
+ return &LayoutStyle::setCy;
case CSSPropertyFlexBasis:
return &LayoutStyle::setFlexBasis;
case CSSPropertyHeight:
@@ -161,14 +165,26 @@ LengthStyleInterpolation::LengthSetter LengthStyleInterpolation::lengthSetterFor
return &LayoutStyle::setPaddingRight;
case CSSPropertyPaddingTop:
return &LayoutStyle::setPaddingTop;
+ case CSSPropertyR:
+ return &LayoutStyle::setR;
+ case CSSPropertyRx:
+ return &LayoutStyle::setRx;
+ case CSSPropertyRy:
+ return &LayoutStyle::setRy;
case CSSPropertyRight:
return &LayoutStyle::setRight;
case CSSPropertyShapeMargin:
return &LayoutStyle::setShapeMargin;
+ case CSSPropertyStrokeDashoffset:
+ return &LayoutStyle::setStrokeDashOffset;
case CSSPropertyTop:
return &LayoutStyle::setTop;
case CSSPropertyWidth:
return &LayoutStyle::setWidth;
+ case CSSPropertyX:
+ return &LayoutStyle::setX;
+ case CSSPropertyY:
+ return &LayoutStyle::setY;
// These properties don't have a LayoutStyle setter with the signature void(*)(const Length&).
case CSSPropertyBaselineShift:
case CSSPropertyBorderBottomWidth:
@@ -180,7 +196,6 @@ LengthStyleInterpolation::LengthSetter LengthStyleInterpolation::lengthSetterFor
case CSSPropertyOutlineOffset:
case CSSPropertyOutlineWidth:
case CSSPropertyPerspective:
- case CSSPropertyStrokeDashoffset:
case CSSPropertyStrokeWidth:
case CSSPropertyVerticalAlign:
case CSSPropertyWebkitBorderHorizontalSpacing:

Powered by Google App Engine
This is Rietveld 408576698