Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 988633004: Linux: Enable ODR violation detection. (try 2) (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Nico, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Enable ODR violation detection. (try 2) BUG=449754 Committed: https://crrev.com/82d64ef43c1d15e1cc25d4b0d38dc314a0f565c0 Cr-Commit-Position: refs/heads/master@{#319577}

Patch Set 1 #

Patch Set 2 : disable for official builds #

Patch Set 3 : taaaaabs! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M build/common.gypi View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 4 chunks +8 lines, -3 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Lei Zhang
Shall we give this another go?
5 years, 9 months ago (2015-03-06 22:59:19 UTC) #2
Nico
sure, lgtm
5 years, 9 months ago (2015-03-06 23:00:45 UTC) #3
chromium-reviews
Hey, TODOne, look at that! :) On Fri, Mar 6, 2015 at 3:00 PM, <thakis@chromium.org> ...
5 years, 9 months ago (2015-03-06 23:11:37 UTC) #4
Ilya Sherman
lgtm
5 years, 9 months ago (2015-03-06 23:58:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988633004/40001
5 years, 9 months ago (2015-03-07 00:02:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/34312)
5 years, 9 months ago (2015-03-07 02:28:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988633004/40001
5 years, 9 months ago (2015-03-07 03:05:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 05:05:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988633004/40001
5 years, 9 months ago (2015-03-07 19:32:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 21:33:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988633004/40001
5 years, 9 months ago (2015-03-08 01:09:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-08 03:56:42 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 03:57:45 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/82d64ef43c1d15e1cc25d4b0d38dc314a0f565c0
Cr-Commit-Position: refs/heads/master@{#319577}

Powered by Google App Engine
This is Rietveld 408576698