third_party/libphonenumber/BUILD.gn - Issue 988633004: Linux: Enable ODR violation detection. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 988633004: Linux: Enable ODR violation detection. (try 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: taaaaabs! Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libphonenumber/BUILD.gn

diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn

index 4c32084ef42b63d77a567ab6036f0a0ba22f24a6..a428292e196cdb08403245d14ccf94be4b63bc6e 100644

--- a/third_party/libphonenumber/BUILD.gn

+++ b/third_party/libphonenumber/BUILD.gn

@@ -45,8 +45,9 @@ static_library("libphonenumber_without_metadata") {

"src/phonenumbers/utf/unilib.cc",

]

- # TODO(scottmg): Temporary until https://codereview.appspot.com/134650043/

- # lands and rolls. http://crbug.com/335824

+ # libphonenumber's base/logging.h is a minimal implementation where DCHECKs

+ # do not consume their arguments. This leads to unused variable warnings in

+ # release builds.

configs -= [ "//build/config/compiler:chromium_code" ]

configs += [ "//build/config/compiler:no_chromium_code" ]

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »