Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: third_party/libphonenumber/libphonenumber.gyp

Issue 988633004: Linux: Enable ODR violation detection. (try 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: taaaaabs! Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'include_dirs': [ 7 'include_dirs': [
8 'src', 8 'src',
9 'src/test', 9 'src/test',
10 # The libphonenumber source (and test code) expects the 10 # The libphonenumber source (and test code) expects the
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 '../../testing/gmock.gyp:gmock', 133 '../../testing/gmock.gyp:gmock',
134 '../../testing/gtest.gyp:gtest', 134 '../../testing/gtest.gyp:gtest',
135 'libphonenumber_without_metadata', 135 'libphonenumber_without_metadata',
136 ], 136 ],
137 'conditions': [ 137 'conditions': [
138 ['OS=="win"', { 138 ['OS=="win"', {
139 'action': [ 139 'action': [
140 '/wo4309', 140 '/wo4309',
141 ], 141 ],
142 }], 142 }],
143 # libphonenumber needs to fix their ODR violations. http://crbug.com/45602 1
144 ['OS=="linux"', {
145 'ldflags!': [
146 '-Wl,--detect-odr-violations',
147 ],
148 }],
143 ], 149 ],
144 }] 150 }]
145 } 151 }
OLDNEW
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698