build/common.gypi - Issue 988633004: Linux: Enable ODR violation detection. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 988633004: Linux: Enable ODR violation detection. (try 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: taaaaabs! Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 6a40e0d13588f9b717d51c6c014d736586787582..4e5bd4312235cdcb28ff28c36c52277e560f22af 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4481,6 +4481,14 @@

# '-Wl,--threads',

# '-Wl,--thread-count=4',

+ 'conditions': [

+ # TODO(thestig): Enable this for disabled cases.

+ [ 'buildtype!="Official" and chromeos==0 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_vptr==0', {

+ 'ldflags': [

+ '-Wl,--detect-odr-violations',

+ ],

+ }],

+ ],

}],

'conditions': [

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »