Use UUID for ServiceWorker Client identifier (2/3, chromium)

Use UUID for ServiceWorker Client identifier (2/3, chromium)

We used to use ServiceWorkerVersion-local identifier for clients but this patch
changes the ID to global UUID one. Since it changes some security assumption
I also added code to check the origin, so that ServiceWorker can only talk to
the clients that are in the same origin.

Spec issue: https://github.com/slightlyoff/ServiceWorker/issues/634
More context: https://github.com/slightlyoff/ServiceWorker/issues/609

To be landed in 3 patches:
1/3: blink-side patch https://crrev.com/990583002/
2/3: THIS
3/3: blink-side cleanup

BUG=464668
Committed: https://crrev.com/eb113ebb7a772b5e7af45bedebe070fe23762b07
Cr-Commit-Position: refs/heads/master@{#320451}

[kinuko, 2015-03-10 13:22:38]

kinuko@chromium.org changed reviewers:
+ nhiroki@chromium.org

[kinuko, 2015-03-11 23:53:47]

PTL

[nhiroki, 2015-03-12 00:29:24]

LGTM

https://codereview.chromium.org/988063004/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/988063004/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_context_core.h:159:
ServiceWorkerProviderHost* provider_host);
nit: indent

https://codereview.chromium.org/988063004/diff/40001/content/common/service_w...
File content/common/service_worker/service_worker_messages.h (right):

https://codereview.chromium.org/988063004/diff/40001/content/common/service_w...
content/common/service_worker/service_worker_messages.h:241: // Sends a
'message' event to a client document (renderer->browser).
nit: "a client document" -> "a client" ?

[kinuko, 2015-03-12 00:59:20]

kinuko@chromium.org changed reviewers:
+ michaeln@chromium.org

[kinuko, 2015-03-12 00:59:35]

kinuko@chromium.org changed reviewers:
+ tsepez@chromium.org

[kinuko, 2015-03-12 00:59:58]

kinuko@chromium.org changed reviewers:
- michaeln@chromium.org, tsepez@chromium.org

[kinuko, 2015-03-12 01:06:45]

kinuko@chromium.org changed reviewers:
+ michaeln@chromium.org, tsepez@chromium.org

[kinuko, 2015-03-12 01:07:00]

Thanks, updated.

https://codereview.chromium.org/988063004/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/988063004/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_context_core.h:159:
ServiceWorkerProviderHost* provider_host);
On 2015/03/12 00:29:24, nhiroki wrote:
> nit: indent

Done.

https://codereview.chromium.org/988063004/diff/40001/content/common/service_w...
File content/common/service_worker/service_worker_messages.h (right):

https://codereview.chromium.org/988063004/diff/40001/content/common/service_w...
content/common/service_worker/service_worker_messages.h:241: // Sends a
'message' event to a client document (renderer->browser).
On 2015/03/12 00:29:24, nhiroki wrote:
> nit: "a client document" -> "a client" ?

Done.

[kinuko, 2015-03-12 01:08:52]

tsepez@: Can you review service_worker_messages.h change? (It has some security
implications as I wrote in the CL description)

Also adding michaeln@ as he might have comments for adding one more
provider_host map in context core, and for X-site transfer handling (it looked
it's ok not to handle this specifically for this patch, but I'm not 100% sure)

[Tom Sepez, 2015-03-12 17:47:54]

I think your origin check is right. LGTM.

[kinuko, 2015-03-13 04:08:08]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2015-03-13 04:08:08]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/988063004/#ps60001 (title:
"addressed comments")

[commit-bot: I haz the power, 2015-03-13 04:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988063004/60001

[commit-bot: I haz the power, 2015-03-13 05:13:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-13 05:13:58]

Patchset 4 (id:??) landed as
https://crrev.com/eb113ebb7a772b5e7af45bedebe070fe23762b07
Cr-Commit-Position: refs/heads/master@{#320451}