content/common/service_worker/service_worker_client_info.cc - Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_client_info.cc

Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_client_info.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_client_info.cc

diff --git a/content/common/service_worker/service_worker_client_info.cc b/content/common/service_worker/service_worker_client_info.cc

index e36af87fa6dc4178c37b22aaad13f9de765d8edb..3d9d554af4f4091304f031d0d3c5a6c6a05e3e0d 100644

--- a/content/common/service_worker/service_worker_client_info.cc

+++ b/content/common/service_worker/service_worker_client_info.cc

@@ -10,8 +10,7 @@

namespace content {

ServiceWorkerClientInfo::ServiceWorkerClientInfo()

- : client_id(kInvalidServiceWorkerClientId),

- page_visibility_state(blink::WebPageVisibilityStateLast),

+ : page_visibility_state(blink::WebPageVisibilityStateLast),

is_focused(false),

frame_type(REQUEST_CONTEXT_FRAME_TYPE_LAST),

client_type(blink::WebServiceWorkerClientTypeLast) {

@@ -23,8 +22,7 @@ ServiceWorkerClientInfo::ServiceWorkerClientInfo(

const GURL& url,

RequestContextFrameType frame_type,

blink::WebServiceWorkerClientType client_type)

- : client_id(kInvalidServiceWorkerClientId),

- page_visibility_state(page_visibility_state),

+ : page_visibility_state(page_visibility_state),

is_focused(is_focused),

url(url),

frame_type(frame_type),

@@ -40,7 +38,7 @@ bool ServiceWorkerClientInfo::IsEmpty() const {

}

bool ServiceWorkerClientInfo::IsValid() const {

- return !IsEmpty() && client_id != kInvalidServiceWorkerClientId;

+ return !IsEmpty() && !client_uuid.empty();

}

} // namespace content