content/common/service_worker/service_worker_messages.h - Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_client_info.cc ('k') | content/renderer/service_worker/embedded_worker_context_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 618c3c68370276b2f7ef71a81ce7ff7b789bf966..a8338c4356e470d8bdcb7abeb9e9923908ca32a1 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -111,7 +111,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::ServiceWorkerVersionAttributes)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::ServiceWorkerClientInfo)

- IPC_STRUCT_TRAITS_MEMBER(client_id)

+ IPC_STRUCT_TRAITS_MEMBER(client_uuid)

IPC_STRUCT_TRAITS_MEMBER(page_visibility_state)

IPC_STRUCT_TRAITS_MEMBER(is_focused)

IPC_STRUCT_TRAITS_MEMBER(url)

@@ -238,10 +238,10 @@ IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_GetClients,

int /* request_id */,

content::ServiceWorkerClientQueryOptions)

-// Sends a 'message' event to a client document (renderer->browser).

+// Sends a 'message' event to a client (renderer->browser).

IPC_MESSAGE_ROUTED3(

- ServiceWorkerHostMsg_PostMessageToDocument,

- int /* client_id */,

+ ServiceWorkerHostMsg_PostMessageToClient,

+ std::string /* uuid */,

base::string16 /* message */,

std::vector<content::TransferredMessagePort> /* sent_message_ports */)

@@ -263,7 +263,7 @@ IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_OpenWindow,

// Ask the browser to focus a client (renderer->browser).

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_FocusClient,

int /* request_id */,

- int /* client_id */)

+ std::string /* uuid */)

// Asks the browser to force this worker to become activated.

IPC_MESSAGE_ROUTED1(ServiceWorkerHostMsg_SkipWaiting,