content/renderer/service_worker/service_worker_script_context.h - Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.h

Issue 988063004: Use UUID for ServiceWorker Client identifier (2/3, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_client.cc ('k') | content/renderer/service_worker/service_worker_script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.h

diff --git a/content/renderer/service_worker/service_worker_script_context.h b/content/renderer/service_worker/service_worker_script_context.h

index 4f435dc3cece56fb677ea53393fa979dc7b27bb5..0ab294dca33f118a2c2f9aeb779e6540e1dff898 100644

--- a/content/renderer/service_worker/service_worker_script_context.h

+++ b/content/renderer/service_worker/service_worker_script_context.h

@@ -80,15 +80,15 @@ class ServiceWorkerScriptContext {

blink::WebServiceWorkerClientCallbacks* callbacks);

void SetCachedMetadata(const GURL& url, const char* data, size_t size);

void ClearCachedMetadata(const GURL& url);

- void PostMessageToDocument(

- int client_id,

+ void PostMessageToClient(

+ const base::string16& uuid,

const base::string16& message,

scoped_ptr<blink::WebMessagePortChannelArray> channels);

void PostCrossOriginMessageToClient(

const blink::WebCrossOriginServiceWorkerClient& client,

const base::string16& message,

scoped_ptr<blink::WebMessagePortChannelArray> channels);

- void FocusClient(int client_id,

+ void FocusClient(const base::string16& uuid,

blink::WebServiceWorkerClientCallbacks* callback);

void SkipWaiting(blink::WebServiceWorkerSkipWaitingCallbacks* callbacks);

void ClaimClients(blink::WebServiceWorkerClientsClaimCallbacks* callbacks);