Refactor favicon to use C++11 loop and fix style violation

Refactor favicon to use C++11 loop and fix style violation

Add DISALLOW_COPY_AND_ASSIGN to abstract base class FaviconClient and
FaviconDriver and turn the destructor virtual and protected.

Use C++11 for loop construct to make the reduce boilerplate and make
the code simpler to read.

Remove unnecessary virtual destructor in non-derived test classes.

Use C++11 nullptr instead of NULL.

BUG=None

Committed: https://crrev.com/a71b8893bff5dfb955cb868d4dcb894055ba312d
Cr-Commit-Position: refs/heads/master@{#320489}

[sdefresne, 2015-03-10 13:35:00]

sdefresne@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[sdefresne, 2015-03-10 13:35:01]

Please take a look.

[pkotwicz, 2015-03-10 14:46:52]

LGTM

Thank you for splitting this into a new CL!

[sdefresne, 2015-03-13 10:18:37]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-03-13 10:18:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/987113005/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-03-13 10:19:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987113005/20001

[commit-bot: I haz the power, 2015-03-13 12:27:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-13 12:28:12]

Patchset 2 (id:??) landed as
https://crrev.com/a71b8893bff5dfb955cb868d4dcb894055ba312d
Cr-Commit-Position: refs/heads/master@{#320489}