Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: components/favicon/core/favicon_driver.h

Issue 987113005: Refactor favicon to use C++11 loop and fix style violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_client
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/browser/favicon_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver.h
diff --git a/components/favicon/core/favicon_driver.h b/components/favicon/core/favicon_driver.h
index fc5c84c32f05aecb8e25e94d93324442e5c9efe5..f06ca0d24048d3776d9d2d10ade03e093af88091 100644
--- a/components/favicon/core/favicon_driver.h
+++ b/components/favicon/core/favicon_driver.h
@@ -16,7 +16,6 @@ class Image;
// implementation must be provided by the driver.
class FaviconDriver {
public:
-
// Starts the download for the given favicon. When finished, the driver
// will call OnDidDownloadFavicon() with the results.
// Returns the unique id of the download request. The id will be passed
@@ -53,6 +52,13 @@ class FaviconDriver {
virtual void OnFaviconAvailable(const gfx::Image& image,
const GURL& icon_url,
bool is_active_favicon) = 0;
+
+ protected:
+ FaviconDriver() {}
+ virtual ~FaviconDriver() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FaviconDriver);
};
#endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
« no previous file with comments | « components/favicon/core/browser/favicon_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698