Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: components/favicon/core/browser/favicon_client.h

Issue 987113005: Refactor favicon to use C++11 loop and fix style violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_client
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
6 #define COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_ 6 #define COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
7 7
8 #include "base/macros.h"
8 #include "components/keyed_service/core/keyed_service.h" 9 #include "components/keyed_service/core/keyed_service.h"
9 10
10 class GURL; 11 class GURL;
11 12
12 // This class abstracts operations that depend on the embedder's environment, 13 // This class abstracts operations that depend on the embedder's environment,
13 // e.g. Chrome. 14 // e.g. Chrome.
14 class FaviconClient : public KeyedService { 15 class FaviconClient : public KeyedService {
15 public: 16 public:
16 ~FaviconClient() override{};
17
18 // Returns true if the specified URL is bookmarked. 17 // Returns true if the specified URL is bookmarked.
19 virtual bool IsBookmarked(const GURL& url) = 0; 18 virtual bool IsBookmarked(const GURL& url) = 0;
19
20 protected:
21 FaviconClient() {}
22 ~FaviconClient() override {}
23
24 private:
25 DISALLOW_COPY_AND_ASSIGN(FaviconClient);
20 }; 26 };
21 27
22 #endif // COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_ 28 #endif // COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698