Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: components/favicon/core/browser/favicon_client.h

Issue 987113005: Refactor favicon to use C++11 loop and fix style violation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_client
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/browser/favicon_client.h
diff --git a/components/favicon/core/browser/favicon_client.h b/components/favicon/core/browser/favicon_client.h
index eeeeac030db9bb56a4f57d1e5310f9f28bf65c5f..d2c276e66687844efe6b691d2664c84c98754028 100644
--- a/components/favicon/core/browser/favicon_client.h
+++ b/components/favicon/core/browser/favicon_client.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
#define COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
+#include "base/macros.h"
#include "components/keyed_service/core/keyed_service.h"
class GURL;
@@ -13,10 +14,15 @@ class GURL;
// e.g. Chrome.
class FaviconClient : public KeyedService {
public:
- ~FaviconClient() override{};
-
// Returns true if the specified URL is bookmarked.
virtual bool IsBookmarked(const GURL& url) = 0;
+
+ protected:
+ FaviconClient() {}
+ ~FaviconClient() override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FaviconClient);
};
#endif // COMPONENTS_FAVICON_CORE_BROWSER_FAVICON_CLIENT_H_
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698