Fix compilation with SK_ENABLE_INST_COUNT=1

Fix compilation with SK_ENABLE_INST_COUNT=1

Add INHERITED declarations to class declarations that prevent
compilation with the flag.

Remove SK_DEFINE_INST_COUNT from all class implementations.  Instead,
use function-local static variables in the reference count helper
classes to create the global instances to store the needed info. The
accessor functions are defined inline in the helper classes, so
definitions are not needed. The initialization point of the variables
should be as well defined as previously.

Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT
instead. This avoids possible future compilation errors further.

For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member
function to all classes that use SK_DECLARE_INST_COUNT and
SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes
contain public INHERITED typedef. This member function seems to be
compiled away. This shouĺd ensure that part of the compilation errors
are caught earlier.

Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses.

Committed: http://code.google.com/p/skia/source/detail?r=12501

[robertphillips, 2013-12-02 14:09:25]

lgtm

[commit-bot: I haz the power, 2013-12-02 14:42:43]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/98703002/1

[commit-bot: I haz the power, 2013-12-02 14:42:47]

Presubmit check for 98703002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

[robertphillips, 2013-12-02 14:57:13]

Brian - can you take a look?

[bsalomon, 2013-12-02 15:19:45]

https://codereview.chromium.org/98703002/diff/1/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

https://codereview.chromium.org/98703002/diff/1/include/core/SkInstCnt.h#newc...
include/core/SkInstCnt.h:126: #define SK_DECLARE_INST_COUNT(className) static
void AddInstChild() { INHERITED::AddInstChild(); }
nice, should we have a comment explaining why this is here? Can something
similar be done for the template version?

Would it make sense to declare in the DECLARE macro and define in the DEFINE
macro to avoid missing DEFINES?

[Kimmo Kinnunen, 2013-12-04 10:35:03]

On 2013/12/02 15:19:45, bsalomon wrote:
> https://codereview.chromium.org/98703002/diff/1/include/core/SkInstCnt.h
> File include/core/SkInstCnt.h (right):
> 
>
https://codereview.chromium.org/98703002/diff/1/include/core/SkInstCnt.h#newc...
> include/core/SkInstCnt.h:126: #define SK_DECLARE_INST_COUNT(className) static
> void AddInstChild() { INHERITED::AddInstChild(); }
> nice, should we have a comment explaining why this is here? Can something
> similar be done for the template version?

Exact same thing was done to the templated version? Did you mean checking
something else too?

Would removing the templated version altogether work?
 
> Would it make sense to declare in the DECLARE macro and define in the DEFINE
> macro to avoid missing DEFINES?

Sounds to me that this would mean linker is involved, maybe link with no
undefined symbols? This sounds to me that it would risk the symbols be not
optimized away, and thus consuming stuff and confusing people? Maybe it's not
worth to have unnecessary symbols in release builds.

If this needs to be solved in this patch, then how about removing the defines
altogether as shown in the new patch?

[bsalomon, 2013-12-04 15:03:43]

I didn't mean to imply that you had to do all this to land it, but thanks! The
change lgtm but I'll defer to Rob who knows that instance counting stuff better
than I do.

[robertphillips, 2013-12-04 15:16:02]

lgtm.

[commit-bot: I haz the power, 2013-12-05 06:07:44]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/98703002/40001

[commit-bot: I haz the power, 2013-12-05 12:08:34]

Change committed as 12501