Some nits I found while looking around rAc() code.

Some nits I found while looking around rAc() code.

R=estade@chromium.org, groby@chromium.org
BUG=none
TEST=smaller diff in next CL

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243137

[Evan Stade, 2014-01-03 20:28:29]

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_types.cc (right):

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_types.cc:24: std::ostream&
operator<<(std::ostream& out, DialogSection section) {
I don't think this should be here.

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/views/a...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (left):

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/views/a...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1931:
delegate_->LabelForSection(section),
this change isn't worth sullying the revision history for

[Dan Beam, 2014-01-03 20:31:04]

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_types.cc (right):

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_types.cc:24: std::ostream&
operator<<(std::ostream& out, DialogSection section) {
On 2014/01/03 20:28:29, Evan Stade wrote:
> I don't think this should be here.

it's not in release builds

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/views/a...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (left):

https://codereview.chromium.org/98693017/diff/30001/chrome/browser/ui/views/a...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1931:
delegate_->LabelForSection(section),
On 2014/01/03 20:28:29, Evan Stade wrote:
> this change isn't worth sullying the revision history for

then write smaller code the first time :)

[groby-ooo-7-16, 2014-01-04 01:05:44]

https://chromiumcodereview.appspot.com/98693017/diff/30001/chrome/browser/ui/...
File chrome/browser/ui/autofill/autofill_dialog_types.cc (right):

https://chromiumcodereview.appspot.com/98693017/diff/30001/chrome/browser/ui/...
chrome/browser/ui/autofill/autofill_dialog_types.cc:24: std::ostream&
operator<<(std::ostream& out, DialogSection section) {
On 2014/01/03 20:31:04, Dan Beam wrote:
> On 2014/01/03 20:28:29, Evan Stade wrote:
> > I don't think this should be here.
> 
> it's not in release builds

See previous comment - I think it should be all or nothing. (See also
autofill::FormData, autofill::CreditCard for autofill examples)

https://chromiumcodereview.appspot.com/98693017/diff/30001/chrome/browser/ui/...
File chrome/browser/ui/autofill/autofill_dialog_types.h (right):

https://chromiumcodereview.appspot.com/98693017/diff/30001/chrome/browser/ui/...
chrome/browser/ui/autofill/autofill_dialog_types.h:79: #ifndef NDEBUG
All other instances of operator<< that a random sample of the code base turned
up[1] are debug & release. I think we should stick to that pattern, if we MUST
have a ToString.

[1] gfx::Range, GURL, various Quick packet items, etc.

[Dan Beam, 2014-01-04 01:14:49]

removed operator<< because the color of my bike shed isn't important enough to
delay other code

[Evan Stade, 2014-01-04 02:13:50]

lgtm

[commit-bot: I haz the power, 2014-01-04 02:14:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/98693017/230001

[commit-bot: I haz the power, 2014-01-04 04:07:43]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-04 11:12:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/98693017/230001

[commit-bot: I haz the power, 2014-01-04 13:53:17]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Dan Beam, 2014-01-06 19:21:24]

Committed patchset #3 manually as r243137 (presubmit successful).