Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 98693017: Some nits I found while looking around rAc() code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_view_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index eebd2e1eca8a00bf070b52d2bc18363028fe3db9..38c29d7034f0147de31ef530539faca06cfe8147 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -1919,15 +1919,11 @@ views::View* AutofillDialogViews::CreateDetailsContainer() {
}
void AutofillDialogViews::CreateDetailsSection(DialogSection section) {
- // Inputs container (manual inputs + combobox).
- views::View* inputs_container = CreateInputsContainer(section);
-
DetailsGroup* group = GroupForSection(section);
// Container (holds label + inputs).
- group->container = new SectionContainer(
- delegate_->LabelForSection(section),
- inputs_container,
- group->suggested_button);
+ group->container = new SectionContainer(delegate_->LabelForSection(section),
+ CreateInputsContainer(section),
+ group->suggested_button);
DCHECK(group->suggested_button->parent());
UpdateDetailsGroupState(*group);
}
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_view_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698