Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 98693017: Some nits I found while looking around rAc() code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index fcfe3c47eff386a66e100d3f3172f47c129be84c..d29a0dcdab428bdc279550c1f28eded742031b86 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -615,8 +615,7 @@ void AutofillDialogControllerImpl::Show() {
// Test whether we need to show the shipping section. If filling that section
// would be a no-op, don't show it.
const DetailInputs& inputs = RequestedFieldsForSection(SECTION_SHIPPING);
- EmptyDataModelWrapper empty_wrapper;
- cares_about_shipping_ = empty_wrapper.FillFormStructure(
+ cares_about_shipping_ = EmptyDataModelWrapper().FillFormStructure(
inputs,
base::Bind(common::DetailInputMatchesField, SECTION_SHIPPING),
&form_structure_);
@@ -2759,7 +2758,6 @@ void AutofillDialogControllerImpl::SuggestionsUpdated() {
std::vector<base::string16> labels;
AutofillProfile::CreateDifferentiatingLabels(profiles, &labels);
DCHECK_EQ(labels.size(), profiles.size());
- const std::string app_locale = g_browser_process->GetApplicationLocale();
for (size_t i = 0; i < profiles.size(); ++i) {
const AutofillProfile& profile = *profiles[i];
if (!HasCompleteAndVerifiedData(profile, requested_shipping_fields_) ||
@@ -2845,11 +2843,10 @@ void AutofillDialogControllerImpl::SuggestionsUpdated() {
void AutofillDialogControllerImpl::FillOutputForSectionWithComparator(
DialogSection section,
const InputFieldComparator& compare) {
- const DetailInputs& inputs = RequestedFieldsForSection(section);
-
if (!SectionIsActive(section))
return;
+ const DetailInputs& inputs = RequestedFieldsForSection(section);
scoped_ptr<DataModelWrapper> wrapper = CreateWrapper(section);
if (wrapper) {
// Only fill in data that is associated with this section.
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698