Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" | 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" |
| 6 | 6 |
| 7 #include <utility> | 7 #include <utility> |
| 8 | 8 |
| 9 #include "base/bind.h" | 9 #include "base/bind.h" |
| 10 #include "base/location.h" | 10 #include "base/location.h" |
| (...skipping 1909 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1920 | 1920 |
| 1921 return details_container_; | 1921 return details_container_; |
| 1922 } | 1922 } |
| 1923 | 1923 |
| 1924 void AutofillDialogViews::CreateDetailsSection(DialogSection section) { | 1924 void AutofillDialogViews::CreateDetailsSection(DialogSection section) { |
| 1925 // Inputs container (manual inputs + combobox). | 1925 // Inputs container (manual inputs + combobox). |
| 1926 views::View* inputs_container = CreateInputsContainer(section); | 1926 views::View* inputs_container = CreateInputsContainer(section); |
| 1927 | 1927 |
| 1928 DetailsGroup* group = GroupForSection(section); | 1928 DetailsGroup* group = GroupForSection(section); |
| 1929 // Container (holds label + inputs). | 1929 // Container (holds label + inputs). |
| 1930 group->container = new SectionContainer( | 1930 group->container = new SectionContainer(delegate_->LabelForSection(section), |
| 1931 delegate_->LabelForSection(section), | 1931 inputs_container, |
|
Evan Stade
2014/01/03 20:28:29
this change isn't worth sullying the revision hist
Dan Beam
2014/01/03 20:31:04
then write smaller code the first time :)
| |
| 1932 inputs_container, | 1932 group->suggested_button); |
| 1933 group->suggested_button); | |
| 1934 DCHECK(group->suggested_button->parent()); | 1933 DCHECK(group->suggested_button->parent()); |
| 1935 UpdateDetailsGroupState(*group); | 1934 UpdateDetailsGroupState(*group); |
| 1936 } | 1935 } |
| 1937 | 1936 |
| 1938 views::View* AutofillDialogViews::CreateInputsContainer(DialogSection section) { | 1937 views::View* AutofillDialogViews::CreateInputsContainer(DialogSection section) { |
| 1939 // The |info_view| holds |manual_inputs| and |suggested_info|, allowing the | 1938 // The |info_view| holds |manual_inputs| and |suggested_info|, allowing the |
| 1940 // dialog to toggle which is shown. | 1939 // dialog to toggle which is shown. |
| 1941 views::View* info_view = new views::View(); | 1940 views::View* info_view = new views::View(); |
| 1942 info_view->SetLayoutManager( | 1941 info_view->SetLayoutManager( |
| 1943 new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0)); | 1942 new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0)); |
| (...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2455 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) | 2454 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) |
| 2456 : section(section), | 2455 : section(section), |
| 2457 container(NULL), | 2456 container(NULL), |
| 2458 manual_input(NULL), | 2457 manual_input(NULL), |
| 2459 suggested_info(NULL), | 2458 suggested_info(NULL), |
| 2460 suggested_button(NULL) {} | 2459 suggested_button(NULL) {} |
| 2461 | 2460 |
| 2462 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} | 2461 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} |
| 2463 | 2462 |
| 2464 } // namespace autofill | 2463 } // namespace autofill |
| OLD | NEW |