Allow expected.txt files in testharness LayoutTests with console errors

Allow expected.txt files in testharness LayoutTests with console errors.

The presubmit check currently does not allow passing testharness tests
to also have an expected.txt file. However, there are some tests that
also include expected console errors, and since testharness cannot check
console messages, it is necessary to check these in the expected.txt
file. This CL modifies the presubmit checker to allow expected.txt files
with testharness tests when they contain a console error.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191654

[jww, 2015-03-09 18:03:43]

jww@chromium.org changed reviewers:
+ dpranke@chromium.org

[jww, 2015-03-09 18:03:43]

Dirk, since you suggested adding this, would you mind doing the honors of this
review? Thanks :-)

[Dirk Pranke, 2015-03-09 22:39:41]

lgtm

[jww, 2015-03-09 22:41:31]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2015-03-09 22:42:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986393003/1

[commit-bot: I haz the power, 2015-03-10 00:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-10 00:47:11]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[jww, 2015-03-10 18:08:42]

The CQ bit was checked by jww@chromium.org

[jww, 2015-03-10 18:08:42]

The CQ bit was unchecked by jww@chromium.org

[jww, 2015-03-10 18:08:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/986393003/#ps20001 (title:
"Fixed test failures")

[commit-bot: I haz the power, 2015-03-10 18:09:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986393003/20001

[commit-bot: I haz the power, 2015-03-10 19:52:07]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191654

[Dirk Pranke, 2015-04-30 16:00:37]

lgtm

https://codereview.chromium.org/986393003/diff/20001/Tools/Scripts/check-test...
File Tools/Scripts/check-testharness-expected-pass (right):

https://codereview.chromium.org/986393003/diff/20001/Tools/Scripts/check-test...
Tools/Scripts/check-testharness-expected-pass:26: not
testharness_results.is_testharness_output_with_console_errors(content):
nit: the expressions should be line wrapped by wrapping them in parens, rather
than using backslashes. I know you didn't start this, but could you fix it?

[jww, 2015-04-30 16:18:37]

Dirk, this mail was my mistake. You approved this CL a while back, and I meant
to send you it's counterpart (https://codereview.chromium.org/1112973002/) for
console warnings. Sorry for the confusion!

https://codereview.chromium.org/986393003/diff/20001/Tools/Scripts/check-test...
File Tools/Scripts/check-testharness-expected-pass (right):

https://codereview.chromium.org/986393003/diff/20001/Tools/Scripts/check-test...
Tools/Scripts/check-testharness-expected-pass:26: not
testharness_results.is_testharness_output_with_console_errors(content):
On 2015/04/30 16:00:37, Dirk Pranke wrote:
> nit: the expressions should be line wrapped by wrapping them in parens, rather
> than using backslashes. I know you didn't start this, but could you fix it?

Done (on the actual CL)