Issue 1112973002: Allow expected.txt files in testharness LayoutTests w/console warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112973002: Allow expected.txt files in testharness LayoutTests w/console warnings (Closed)

Created:
5 years, 7 months ago by jww

Modified:
5 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Allow expected.txt files in testharness LayoutTests w/console warnings Adds an exception to the presubmit check so that expected.txt files with console warnings are allowed for an otherwise passing test. This is the console warning counterpart to https://codereview.chromium.org/986393003. R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194761

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
M	Tools/Scripts/check-testharness-expected-pass	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112973002/20001

5 years, 7 months ago (2015-04-30 16:54:16 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 18:11:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194761