Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2199)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

Issue 986393003: Allow expected.txt files in testharness LayoutTests with console errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed test failures Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py b/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
index 9bc87a8f585675c0c420448782caf66fbef4a423..570074c4afcc9e89a1e0969b40bb8a7d1af7b2f9 100644
--- a/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
+++ b/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py
@@ -79,3 +79,20 @@ def is_testharness_output_passing(content_text):
return False
return True
+
+
+def is_testharness_output_with_console_errors(content_text):
+ """
+ Returns whether the content_text in parameter is a testharness output with
+ console errors.
+
+ Note:
+ It is expected that the |content_text| is a testharness output.
+ """
+
+ lines = content_text.strip().splitlines()
+ for line in lines:
+ if line.startswith('CONSOLE ERROR:'):
+ return True
+
+ return False

Powered by Google App Engine
This is Rietveld 408576698