Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: Tools/Scripts/check-testharness-expected-pass

Issue 986393003: Allow expected.txt files in testharness LayoutTests with console errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed test failures Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/check-testharness-expected-pass
diff --git a/Tools/Scripts/check-testharness-expected-pass b/Tools/Scripts/check-testharness-expected-pass
index 3d7e992253c14fa99fd782adb298276a2ddd2566..519132d6ca0a735f082a88b2f32e649ff3f0b01c 100755
--- a/Tools/Scripts/check-testharness-expected-pass
+++ b/Tools/Scripts/check-testharness-expected-pass
@@ -22,11 +22,12 @@ paths = []
for path in sys.argv[1:]:
content = open(path, 'r').read()
if testharness_results.is_testharness_output(content) and \
- testharness_results.is_testharness_output_passing(content):
+ testharness_results.is_testharness_output_passing(content) and \
+ not testharness_results.is_testharness_output_with_console_errors(content):
Dirk Pranke 2015/04/30 16:00:37 nit: the expressions should be line wrapped by wra
jww 2015/04/30 16:18:37 Done (on the actual CL)
paths.append(path)
if len(paths) > 0:
- sys.stderr.write('* The following files are passing testharness results, they should be removed:\n ')
+ sys.stderr.write('* The following files are passing testharness results without console error messages, they should be removed:\n ')
sys.stderr.write('\n '.join(paths))
sys.stderr.write('\n')
- sys.exit("ERROR: found passing testharness results.")
+ sys.exit("ERROR: found passing testharness results without console error messages.")
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698