Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9844008: Using DidCommitProvisionalLoad() instead of DidStartProvisionalLoad() in USIS. (Closed)

Created:
8 years, 9 months ago by eaugusti
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Using DidCommitProvisionalLoad() instead of DidStartProvisionalLoad() in USIS. When the download is started, DidStartProvisionalLoad() is called which in-turn causes UserScriptIdleSchedule to abandon its user scrips. However, the provisional load is then abandoned. To fix this, this patch only informs the USIS of a provisional load on DidCommitProvisionalLoad(), which does not happen on a downlaod attempt. BUG=104853 TEST=Have an extension that calls chrome.tabs.executeScript(). Start a download that does not redirect the page. Now try having the extension executeScript(). Before this patch: the inject will not happen. After this patch: the inject will happen.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/renderer/extensions/extension_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
lgtm
8 years, 8 months ago (2012-03-30 20:43:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eaugusti@chromium.org/9844008/1
8 years, 8 months ago (2012-03-30 20:51:04 UTC) #2
commit-bot: I haz the power
8 years, 8 months ago (2012-03-30 22:06:42 UTC) #3
Try job failure for 9844008-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698