Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/renderer/extensions/extension_helper.h

Issue 9844008: Using DidCommitProvisionalLoad() instead of DidStartProvisionalLoad() in USIS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_ 5 #ifndef CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_
6 #define CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_ 6 #define CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 int browser_window_id() const { return browser_window_id_; } 50 int browser_window_id() const { return browser_window_id_; }
51 content::ViewType view_type() const { return view_type_; } 51 content::ViewType view_type() const { return view_type_; }
52 52
53 private: 53 private:
54 // RenderViewObserver implementation. 54 // RenderViewObserver implementation.
55 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 55 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
56 virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE; 56 virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
57 virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE; 57 virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
58 virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE; 58 virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE;
59 virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame) OVERRIDE; 59 virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame,
60 bool is_new_navigation) OVERRIDE;
60 virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE; 61 virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;
61 virtual void DidCreateDataSource(WebKit::WebFrame* frame, 62 virtual void DidCreateDataSource(WebKit::WebFrame* frame,
62 WebKit::WebDataSource* ds) OVERRIDE; 63 WebKit::WebDataSource* ds) OVERRIDE;
63 64
64 void OnExtensionResponse(int request_id, bool success, 65 void OnExtensionResponse(int request_id, bool success,
65 const std::string& response, 66 const std::string& response,
66 const std::string& error); 67 const std::string& error);
67 void OnExtensionMessageInvoke(const std::string& extension_id, 68 void OnExtensionMessageInvoke(const std::string& extension_id,
68 const std::string& function_name, 69 const std::string& function_name,
69 const base::ListValue& args, 70 const base::ListValue& args,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 // Type of view attached with RenderView. 112 // Type of view attached with RenderView.
112 content::ViewType view_type_; 113 content::ViewType view_type_;
113 114
114 // Id number of browser window which RenderView is attached to. 115 // Id number of browser window which RenderView is attached to.
115 int browser_window_id_; 116 int browser_window_id_;
116 117
117 DISALLOW_COPY_AND_ASSIGN(ExtensionHelper); 118 DISALLOW_COPY_AND_ASSIGN(ExtensionHelper);
118 }; 119 };
119 120
120 #endif // CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_ 121 #endif // CHROME_RENDERER_EXTENSIONS_EXTENSION_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698