Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess (Closed)

Created:
5 years, 9 months ago by rvargas (doing something else)
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, jam, darin-cc_chromium.org, kalyank, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redefine base::Process:Terminate so that it can replace base::KillProcess BUG=417532 Committed: https://crrev.com/eedb763e54c4c79c7110c2daa21435a390982a71 Cr-Commit-Position: refs/heads/master@{#319776}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase + typo #

Patch Set 3 : Add const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M ash/test/test_metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M base/process/process_posix.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M base/process/process_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process/process_win.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/stress_cache/stress_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
https://codereview.chromium.org/983963002/diff/1/base/process/process.h File base/process/process.h (right): https://codereview.chromium.org/983963002/diff/1/base/process/process.h#newcode95 base/process/process.h:95: // be the exit code of the process. if ...
5 years, 9 months ago (2015-03-06 19:57:08 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-09 20:42:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983963002/40001
5 years, 9 months ago (2015-03-09 21:16:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 23:53:52 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:55:16 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/eedb763e54c4c79c7110c2daa21435a390982a71
Cr-Commit-Position: refs/heads/master@{#319776}

Powered by Google App Engine
This is Rietveld 408576698