base/process/process_unittest.cc - Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_unittest.cc

Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/process_unittest.cc

diff --git a/base/process/process_unittest.cc b/base/process/process_unittest.cc

index 535a36fdf12d70850282148cd17bcaa61a8de5b0..ba8e4e6f68820c0827a463c63d0022e588a689bb 100644

--- a/base/process/process_unittest.cc

+++ b/base/process/process_unittest.cc

@@ -123,7 +123,7 @@ TEST_F(ProcessTest, Terminate) {

exit_code = kDummyExitCode;

int kExpectedExitCode = 250;

- process.Terminate(kExpectedExitCode);

+ process.Terminate(kExpectedExitCode, false);

process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),

&exit_code);

@@ -160,7 +160,7 @@ TEST_F(ProcessTest, WaitForExitWithTimeout) {

EXPECT_FALSE(process.WaitForExitWithTimeout(timeout, &exit_code));

EXPECT_EQ(kDummyExitCode, exit_code);

- process.Terminate(kDummyExitCode);

+ process.Terminate(kDummyExitCode, false);

}

// Ensure that the priority of a process is restored correctly after

« no previous file with comments | « base/process/process_posix.cc ('k') | base/process/process_win.cc » ('j') | no next file with comments »