components/browser_watcher/exit_code_watcher_win_unittest.cc - Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/exit_code_watcher_win_unittest.cc

Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/browser_watcher/exit_code_watcher_win_unittest.cc

diff --git a/components/browser_watcher/exit_code_watcher_win_unittest.cc b/components/browser_watcher/exit_code_watcher_win_unittest.cc

index 3e1728c1513aeb086ad8a87f4aa668e996718d63..e73953635fa11d52ea62d8236833ce0061a7b5ab 100644

--- a/components/browser_watcher/exit_code_watcher_win_unittest.cc

+++ b/components/browser_watcher/exit_code_watcher_win_unittest.cc

@@ -38,7 +38,7 @@ class ScopedSleeperProcess {

~ScopedSleeperProcess() {

if (process_.IsValid()) {

- process_.Terminate(-1);

+ process_.Terminate(-1, false);

int exit_code = 0;

EXPECT_TRUE(process_.WaitForExit(&exit_code));

}

@@ -57,7 +57,7 @@ class ScopedSleeperProcess {

void Kill(int exit_code, bool wait) {

ASSERT_TRUE(process_.IsValid());

ASSERT_FALSE(is_killed_);

- process_.Terminate(exit_code);

+ process_.Terminate(exit_code, false);

int seen_exit_code = 0;

EXPECT_TRUE(process_.WaitForExit(&seen_exit_code));

EXPECT_EQ(exit_code, seen_exit_code);

« no previous file with comments | « base/process/process_win.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »