net/tools/stress_cache/stress_cache.cc - Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/stress_cache/stress_cache.cc

Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/stress_cache/stress_cache.cc

diff --git a/net/tools/stress_cache/stress_cache.cc b/net/tools/stress_cache/stress_cache.cc

index b63ce2111867038cabe7076c037e45be2cfaa79c..d67ebddb52a39463d8ebaf4dc0d69b8a461ae7cb 100644

--- a/net/tools/stress_cache/stress_cache.cc

+++ b/net/tools/stress_cache/stress_cache.cc

@@ -204,7 +204,7 @@ void CrashCallback() {

printf("sweet death...\n");

#if defined(OS_WIN)

// Windows does more work on _exit() than we would like.

- base::Process::Current().Terminate(kExpectedCrash);

+ base::Process::Current().Terminate(kExpectedCrash, false);

#elif defined(OS_POSIX)

// On POSIX, _exit() will terminate the process with minimal cleanup,

// and it is cleaner than killing.

« no previous file with comments | « content/browser/child_process_launcher.cc ('k') | win8/delegate_execute/delegate_execute.cc » ('j') | no next file with comments »