Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 982313002: Closing a persistent notification should be aware of the origin. (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closing a persistent notification should be aware of the origin. Update Chromium to pass in the origin of a persistent notification in the IPC message. The browser process isn't currently using this yet, but that will follow shortly. This is part of a three-sided patch: [1] This patch. [2] https://codereview.chromium.org/985063002/ [3] https://codereview.chromium.org/985693004/ BUG=447628 Committed: https://crrev.com/198c7dd6be05b7a447a4853ef849a10f9ebf65c8 Cr-Commit-Position: refs/heads/master@{#319463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M content/browser/notifications/notification_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
PTAL
5 years, 9 months ago (2015-03-06 15:53:08 UTC) #2
Mike West
LGTM, but you'll need an OWNER.
5 years, 9 months ago (2015-03-06 15:55:39 UTC) #3
Peter Beverloo
On 2015/03/06 15:55:39, Mike West wrote: > LGTM, but you'll need an OWNER. Which'd be ...
5 years, 9 months ago (2015-03-06 15:56:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982313002/1
5 years, 9 months ago (2015-03-06 17:05:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 18:01:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 18:02:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/198c7dd6be05b7a447a4853ef849a10f9ebf65c8
Cr-Commit-Position: refs/heads/master@{#319463}

Powered by Google App Engine
This is Rietveld 408576698