content/child/notifications/notification_manager.h - Issue 982313002: Closing a persistent notification should be aware of the origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_manager.h

Issue 982313002: Closing a persistent notification should be aware of the origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_message_filter.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_manager.h

diff --git a/content/child/notifications/notification_manager.h b/content/child/notifications/notification_manager.h

index ee64f3c10638cbe1dc88e687ca3b24ff16f9aee5..d92edc8044454cb0d157d9be223a7e8db40febe9 100644

--- a/content/child/notifications/notification_manager.h

+++ b/content/child/notifications/notification_manager.h

@@ -47,6 +47,10 @@ class NotificationManager : public blink::WebNotificationManager,

blink::WebNotificationShowCallbacks* callbacks);

virtual void close(blink::WebNotificationDelegate* delegate);

virtual void closePersistent(

+ const blink::WebSerializedOrigin& origin,

+ const blink::WebString& persistent_notification_id);

+ // TODO(peter): Remove this method when Blink has been updated.

+ virtual void closePersistent(

const blink::WebString& persistent_notification_id);

virtual void notifyDelegateDestroyed(

blink::WebNotificationDelegate* delegate);