content/common/platform_notification_messages.h - Issue 982313002: Closing a persistent notification should be aware of the origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 982313002: Closing a persistent notification should be aware of the origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index 778574c6bd58011121106d95a8ec4ec8d687b5c3..2ce6af8edbea8c9fdb75d514575cd6dc1e05a41b 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -59,7 +59,8 @@ IPC_MESSAGE_CONTROL4(PlatformNotificationHostMsg_ShowPersistent,

IPC_MESSAGE_CONTROL1(PlatformNotificationHostMsg_Close,

int /* notification_id */)

-IPC_MESSAGE_CONTROL1(PlatformNotificationHostMsg_ClosePersistent,

+IPC_MESSAGE_CONTROL2(PlatformNotificationHostMsg_ClosePersistent,

+ GURL /* origin */,

std::string /* persistent_notification_id */)

IPC_SYNC_MESSAGE_CONTROL1_1(PlatformNotificationHostMsg_CheckPermission,

« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | no next file » | no next file with comments »