Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 982313002: Closing a persistent notification should be aware of the origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_message_filter.cc
diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc
index b41b3781bac8ea36b69236c066ff45ff98b877c1..9d2976ba8e6006fee2a574818d62056c7f29f076 100644
--- a/content/browser/notifications/notification_message_filter.cc
+++ b/content/browser/notifications/notification_message_filter.cc
@@ -129,6 +129,7 @@ void NotificationMessageFilter::OnClosePlatformNotification(
}
void NotificationMessageFilter::OnClosePersistentNotification(
+ const GURL& origin,
const std::string& persistent_notification_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -136,6 +137,9 @@ void NotificationMessageFilter::OnClosePersistentNotification(
GetContentClient()->browser()->GetPlatformNotificationService();
DCHECK(service);
+ // TODO(peter): Use |service_worker_registration_id| and |origin| when feeding
+ // the close event through the notification database.
+
service->ClosePersistentNotification(browser_context_,
persistent_notification_id);
}
« no previous file with comments | « content/browser/notifications/notification_message_filter.h ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698