Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 978213003: 4-at-a-time SkPMColor -> SkPMFloat API. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, msarett
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

4-at-a-time SkPMColor -> SkPMFloat API. Please see if this looks usable. It may even give a perf boost if you use it, even without custom implementations for each instruction set. I've been trying this morning to beat this naive loop implementation, but so far no luck with either _SSE2.h or _SSSE3.h. It's possible this is an artifact of the microbenchmark, because we're not doing anything between the conversions. I'd like to see how this fits into real code, what assembly's generated, what the hot spots are, etc. I've updated the tests to test these new APIs, and splintered off a pair of new benchmarks that use the new APIs. This required some minor rejiggering in the benches. BUG=skia: Committed: https://skia.googlesource.com/skia/+/548bf38b28986fab6770350b72247d7114d98184

Patch Set 1 #

Patch Set 2 : tweak bench #

Patch Set 3 : template bench #

Patch Set 4 : just APIs, bench, and test #

Patch Set 5 : const #

Patch Set 6 : 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -12 lines) Patch
M bench/PMFloatBench.cpp View 1 2 3 4 5 2 chunks +49 lines, -12 lines 0 comments Download
M src/core/SkPMFloat.h View 1 2 3 4 5 2 chunks +16 lines, -0 lines 0 comments Download
M tests/PMFloatTest.cpp View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
5 years, 9 months ago (2015-03-05 19:08:41 UTC) #2
reed1
Looks usable. lgtm bikeshed : From4PMColors, etc.? I think I'd like the name to some ...
5 years, 9 months ago (2015-03-05 19:22:44 UTC) #3
mtklein
On 2015/03/05 19:22:44, reed1 wrote: > Looks usable. lgtm > > bikeshed : From4PMColors, etc.? ...
5 years, 9 months ago (2015-03-05 19:25:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978213003/100001
5 years, 9 months ago (2015-03-05 19:26:44 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 19:32:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/548bf38b28986fab6770350b72247d7114d98184

Powered by Google App Engine
This is Rietveld 408576698