Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 977773002: Update SkPMFloat API a bit. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update SkPMFloat API a bit. Instead of set(SkPMColor), add a constructor SkPMFloat(SkPMColor). Replace setA(), setR(), etc. with a 4 float constructor. And, promise to stick to SkPMColor order. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4e644f5d5020a6ec904734a3f521bfad173cb450

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : update #

Patch Set 4 : fix copy and assign #

Patch Set 5 : 32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -46 lines) Patch
M bench/PMFloatBench.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPMFloat.h View 1 2 3 3 chunks +23 lines, -13 lines 0 comments Download
M src/opts/SkPMFloat_SSE2.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/opts/SkPMFloat_SSSE3.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/opts/SkPMFloat_neon.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/opts/SkPMFloat_none.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M tests/PMFloatTest.cpp View 3 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mtklein_C
5 years, 9 months ago (2015-03-04 00:21:32 UTC) #2
reed1
lgtm w/ suggestion for future factories https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h File src/core/SkPMFloat.h (right): https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h#newcode12 src/core/SkPMFloat.h:12: explicit SkPMFloat(SkPMColor); I'm ...
5 years, 9 months ago (2015-03-04 16:00:38 UTC) #3
mtklein
On 2015/03/04 16:00:38, reed1 wrote: > lgtm w/ suggestion for future factories > > https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h ...
5 years, 9 months ago (2015-03-04 16:17:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977773002/1
5 years, 9 months ago (2015-03-04 16:18:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/2345)
5 years, 9 months ago (2015-03-04 16:19:16 UTC) #8
mtklein
Had enough bugs in here that I added in the factories too. https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h File src/core/SkPMFloat.h ...
5 years, 9 months ago (2015-03-04 18:16:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977773002/30007
5 years, 9 months ago (2015-03-04 19:13:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/2351)
5 years, 9 months ago (2015-03-04 19:15:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977773002/70001
5 years, 9 months ago (2015-03-04 19:18:40 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:25:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/4e644f5d5020a6ec904734a3f521bfad173cb450

Powered by Google App Engine
This is Rietveld 408576698