Update SkPMFloat API a bit.

Update SkPMFloat API a bit.

Instead of set(SkPMColor), add a constructor SkPMFloat(SkPMColor).
Replace setA(), setR(), etc. with a 4 float constructor.

And, promise to stick to SkPMColor order.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4e644f5d5020a6ec904734a3f521bfad173cb450

[mtklein_C, 2015-03-04 00:21:32]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[reed1, 2015-03-04 16:00:38]

lgtm w/ suggestion for future factories

https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h
File src/core/SkPMFloat.h (right):

https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h#newcode12
src/core/SkPMFloat.h:12: explicit SkPMFloat(SkPMColor);
I'm not sure if constructors are "safer" than factories, since the constructor
can't "name" its parameters. Can we try adding factories for these as well, and
then see how people used it?

e.g.

static SkPMFloat NewFromPMColor(...);
static SkPMFloat NewARGB(float ...)
(or other names/variants)

[mtklein, 2015-03-04 16:17:21]

On 2015/03/04 16:00:38, reed1 wrote:
> lgtm w/ suggestion for future factories
> 
> https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h
> File src/core/SkPMFloat.h (right):
> 
>
https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h#newcode12
> src/core/SkPMFloat.h:12: explicit SkPMFloat(SkPMColor);
> I'm not sure if constructors are "safer" than factories, since the constructor
> can't "name" its parameters. Can we try adding factories for these as well,
and
> then see how people used it?
> 
> e.g.
> 
> static SkPMFloat NewFromPMColor(...);
> static SkPMFloat NewARGB(float ...)
> (or other names/variants)

Yep, sg.

[mtklein, 2015-03-04 16:17:24]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-03-04 16:18:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977773002/1

[commit-bot: I haz the power, 2015-03-04 16:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 16:19:16]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[mtklein, 2015-03-04 18:16:00]

Had enough bugs in here that I added in the factories too.

https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h
File src/core/SkPMFloat.h (right):

https://codereview.chromium.org/977773002/diff/1/src/core/SkPMFloat.h#newcode12
src/core/SkPMFloat.h:12: explicit SkPMFloat(SkPMColor);
On 2015/03/04 16:00:38, reed1 wrote:
> I'm not sure if constructors are "safer" than factories, since the constructor
> can't "name" its parameters. Can we try adding factories for these as well,
and
> then see how people used it?
> 
> e.g.
> 
> static SkPMFloat NewFromPMColor(...);
> static SkPMFloat NewARGB(float ...)
> (or other names/variants)

Done.

[mtklein, 2015-03-04 19:06:06]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-03-04 19:06:06]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/977773002/#ps30007 (title:
"fix copy and assign")

[commit-bot: I haz the power, 2015-03-04 19:13:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977773002/30007

[commit-bot: I haz the power, 2015-03-04 19:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 19:15:04]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[mtklein, 2015-03-04 19:18:23]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-03-04 19:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/977773002/#ps70001 (title:
"32")

[commit-bot: I haz the power, 2015-03-04 19:18:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977773002/70001

[commit-bot: I haz the power, 2015-03-04 19:25:30]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/4e644f5d5020a6ec904734a3f521bfad173cb450