Serializer: correctly deal with internal references.

Serializer: correctly deal with internal references.

Internal references are absolute addresses into the instruction
stream. Turn them into relative addresses when serializing and
back when deserializing to keep them valid.

R=bmeurer@chromium.org

Committed: https://crrev.com/ce45b00e4bd661e5c12a33a40565b29f1ea279e2
Cr-Commit-Position: refs/heads/master@{#27020}

[Benedikt Meurer, 2015-03-03 13:56:22]

lgtm

[Yang, 2015-03-03 14:04:31]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-03 14:04:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps20001 (title:
"platform ports")

[commit-bot: I haz the power, 2015-03-03 14:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/20001

[commit-bot: I haz the power, 2015-03-03 14:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 14:09:43]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/1951)

[Yang, 2015-03-03 15:11:39]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-03 15:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps40001 (title:
"no turbo deoptimization")

[commit-bot: I haz the power, 2015-03-03 15:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/40001

[commit-bot: I haz the power, 2015-03-03 15:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 15:16:32]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/1956)

[Yang, 2015-03-04 09:15:02]

yangguo@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Yang, 2015-03-04 09:15:02]

Fixed ports. On non-Intel platforms internal references and external references
are accessed differently via reloc info.

@mstarzinger: I also turned off context specialization for asm if the code is
intended to end up in a snapshot. In this case, obviously we want to share code
across all contexts that is instantiated from the snapshot, so context
specialization makes no sense. This currently only affects the particular test
case in this CL, but if we decide to include Turbofan code in the snapshot in
the future, this will be necessary.

[Michael Starzinger, 2015-03-04 13:43:50]

Summary of offline discussion.

https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc#newcode516
src/compiler.cc:516: !isolate()->serializer_enabled()) {
As discussed offline: Instead of narrowing the intake valve of this entry into
the pipeline, I actually propose widening the intake valve of
Compiler::GetLazyCode when --turbo-filter=foo (and for now --always-opt) is
passed. This should increase overall coverage instead of limiting it.

https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-seriali...
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-seriali...
test/cctest/test-serialize.cc:1519: "  'use asm';"
As discussed offline: I don't think we want to trigger TurboFan with this
directive, because what we want to test here is not serialization of asm code
but is serialization of non-context-specialized TurboFan code. So we should try
to use the regular --turbo-filter=foo approach here.

[Yang, 2015-03-04 14:44:01]

On 2015/03/04 13:43:50, Michael Starzinger wrote:
> Summary of offline discussion.
> 
> https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc
> File src/compiler.cc (right):
> 
>
https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc#newcode516
> src/compiler.cc:516: !isolate()->serializer_enabled()) {
> As discussed offline: Instead of narrowing the intake valve of this entry into
> the pipeline, I actually propose widening the intake valve of
> Compiler::GetLazyCode when --turbo-filter=foo (and for now --always-opt) is
> passed. This should increase overall coverage instead of limiting it.
> 
>
https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-seriali...
> File test/cctest/test-serialize.cc (right):
> 
>
https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-seriali...
> test/cctest/test-serialize.cc:1519: "  'use asm';"
> As discussed offline: I don't think we want to trigger TurboFan with this
> directive, because what we want to test here is not serialization of asm code
> but is serialization of non-context-specialized TurboFan code. So we should
try
> to use the regular --turbo-filter=foo approach here.

Michael, thanks for the suggestion and the patch!

[Yang, 2015-03-04 14:44:08]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-04 14:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps80001 (title:
"Michael's patch")

[commit-bot: I haz the power, 2015-03-04 14:45:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/80001

[Michael Starzinger, 2015-03-04 14:47:27]

LGTM, I only looked at compiler.cc and the test case.

[commit-bot: I haz the power, 2015-03-04 15:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 15:23:19]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Yang, 2015-03-05 09:40:37]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-05 09:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-03-05 09:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/120001

[Yang, 2015-03-05 09:53:56]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2015-03-05 09:55:35]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-05 09:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps140001
(title: "restore test case")

[commit-bot: I haz the power, 2015-03-05 09:59:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/140001

[commit-bot: I haz the power, 2015-03-05 10:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 10:45:33]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Yang, 2015-03-05 12:02:57]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-05 12:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps160001
(title: "fix memleak due to flags")

[commit-bot: I haz the power, 2015-03-05 12:04:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/160001

[commit-bot: I haz the power, 2015-03-05 12:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 12:22:06]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Yang, 2015-03-05 13:44:24]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-05 13:44:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/976623002/#ps180001
(title: "argh I keep making mistakes.")

[commit-bot: I haz the power, 2015-03-05 13:44:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976623002/180001

[commit-bot: I haz the power, 2015-03-05 13:46:36]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-03-05 13:46:58]

Patchset 10 (id:??) landed as
https://crrev.com/ce45b00e4bd661e5c12a33a40565b29f1ea279e2
Cr-Commit-Position: refs/heads/master@{#27020}