src/assembler.cc - Issue 976623002: Serializer: correctly deal with internal references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.cc

Issue 976623002: Serializer: correctly deal with internal references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: argh I keep making mistakes. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/assembler.cc

diff --git a/src/assembler.cc b/src/assembler.cc

index 86d4b11aeb5d113d5f1adce63e07f341a183de6a..9ad8bc613d232035246071ab5138cd58db416ead 100644

--- a/src/assembler.cc

+++ b/src/assembler.cc

@@ -861,8 +861,9 @@ void RelocInfo::Print(Isolate* isolate, std::ostream& os) { // NOLINT

os << " (" << Brief(target_object()) << ")";

} else if (rmode_ == EXTERNAL_REFERENCE) {

ExternalReferenceEncoder ref_encoder(isolate);

- os << " (" << ref_encoder.NameOfAddress(target_reference()) << ") ("

- << static_cast<const void*>(target_reference()) << ")";

+ os << " (" << ref_encoder.NameOfAddress(target_external_reference())

+ << ") (" << static_cast<const void*>(target_external_reference())

+ << ")";

} else if (IsCodeTarget(rmode_)) {

Code* code = Code::GetCodeFromTargetAddress(target_address());

os << " (" << Code::Kind2String(code->kind()) << ") ("

« no previous file with comments | « src/assembler.h ('k') | src/compiler.cc » ('j') | no next file with comments »