Serializer: correctly deal with internal references.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 
 #include "src/ast-numbering.h"
 #include "src/bootstrapper.h"
@@ skipping 492 matching lines @@
   if ((FLAG_turbo_asm && info()->shared_info()->asm_function()) ||
       info()->closure()->PassesFilter(FLAG_turbo_filter)) {
     if (FLAG_trace_opt) {
       OFStream os(stdout);
       os << "[compiling method " << Brief(*info()->closure())
          << " using TurboFan";
       if (info()->is_osr()) os << " OSR";
       os << "]" << std::endl;
     }
 
-    if (info()->shared_info()->asm_function()) {
+    // Do not enable context specialization if the code is intended to be
+    // included in a start-up snapshot.
+    if (info()->shared_info()->asm_function() &&
+        !isolate()->serializer_enabled()) {

[Michael Starzinger, 2015/03/04 13:43:50]

As discussed offline: Instead of narrowing the intake valve of this entry into
the pipeline, I actually propose widening the intake valve of
Compiler::GetLazyCode when --turbo-filter=foo (and for now --always-opt) is
passed. This should increase overall coverage instead of limiting it.

       info()->MarkAsContextSpecializing();
     }
 
     Timer t(this, &time_taken_to_create_graph_);
     compiler::Pipeline pipeline(info());
     pipeline.GenerateCode();
     if (!info()->code().is_null()) {
       return SetLastStatus(SUCCEEDED);
     }
   }
@@ skipping 416 matching lines @@
   // deopt from turbofan code.
   if (FLAG_turbo_asm && function->shared()->asm_function() &&
       (FLAG_turbo_deoptimization || !isolate->debug()->is_active()) &&
       !FLAG_turbo_osr) {
     CompilationInfoWithZone info(function);
 
     VMState<COMPILER> state(isolate);
     PostponeInterruptsScope postpone(isolate);
 
     info.SetOptimizing(BailoutId::None(), handle(function->shared()->code()));
-    info.MarkAsContextSpecializing();
+
+    // Do not enable context specialization if the code is intended to be
+    // included in a start-up snapshot.
+    if (!isolate->serializer_enabled()) info.MarkAsContextSpecializing();
 
     if (GetOptimizedCodeNow(&info)) {
       DCHECK(function->shared()->is_compiled());
       return info.code();
     }
     // We have failed compilation. If there was an exception clear it so that
     // we can compile unoptimized code.
     if (isolate->has_pending_exception()) isolate->clear_pending_exception();
   }
 
@@ skipping 648 matching lines @@
 }
 
 
 #if DEBUG
 void CompilationInfo::PrintAstForTesting() {
   PrintF("--- Source from AST ---\n%s\n",
          PrettyPrinter(isolate(), zone()).PrintProgram(function()));
 }
 #endif
 } }  // namespace v8::internal