Refactor BinaryOpIC to be able to use different stubs.

Refactor BinaryOpIC to be able to use different stubs.

Previously BinaryOpIC and BinaryOpStub were pretty much interdependent.
However, in order to use allocation sites for string adds on-demand,
we need to be able to use different stubs (with a different number of
register parameters, via trampolines) depending on the BinaryOpIC state.

R=hpayer@chromium.org, mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18191

[Benedikt Meurer, 2013-11-30 14:16:19]

Hey Hannes, Michael,
This is the necessary BinaryOpIC refactoring. Based on this CL, we can add
additional stubs to the BinaryOpIC, also supporting trampolines that setup
allocation sites.
The interesting part of this CL is the new BinaryOpIC::State class, which
encapsulates all state of a BinaryOpIC and can be used by all stubs, handlers
and trampolines that may be used by the BinaryOpIC.
There's still some open refactoring (i.e. fixing some of Andreas TODOs wrt
BinaryOps, but that's not critical right now).
PTAL
-- Benedikt

[mvstanton, 2013-12-02 09:59:32]

I really like pulling the state into a separate class instead of having to
instantiate the stub to figure that out. One nit, and lgtm.

https://codereview.chromium.org/97543002/diff/40001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/97543002/diff/40001/src/code-stubs.h#newcode1068
src/code-stubs.h:1068: static void GenerateAheadOfTime(Isolate* isolate) {
Nit: could this be in code-stubs.cc instead of defined inline?

[Benedikt Meurer, 2013-12-02 10:23:45]

https://codereview.chromium.org/97543002/diff/40001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/97543002/diff/40001/src/code-stubs.h#newcode1068
src/code-stubs.h:1068: static void GenerateAheadOfTime(Isolate* isolate) {
On 2013/12/02 09:59:33, mvstanton wrote:
> Nit: could this be in code-stubs.cc instead of defined inline?

Done.

[Hannes Payer (out of office), 2013-12-02 11:39:00]

LGTM, just one comment nit

https://codereview.chromium.org/97543002/diff/80001/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/97543002/diff/80001/src/log.cc#newcode1841
src/log.cc:1841: case Code::BINARY_OP_IC:
you may wanna add the "// fall through" comment for consistency

[Benedikt Meurer, 2013-12-02 13:14:21]

Committed patchset #3 manually as r18191 (presubmit successful).