src/log.cc - Issue 97543002: Refactor BinaryOpIC to be able to use different stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 97543002: Refactor BinaryOpIC to be able to use different stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index e123231292e288e33c94bd5b37980d94ca04b08b..a508e8739ea4b58de7502d06f600f177cefaa304 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1838,12 +1838,7 @@ void Logger::LogCodeObject(Object* object) {

case Code::FUNCTION:

case Code::OPTIMIZED_FUNCTION:

return; // We log this later using LogCompiledFunctions.

- case Code::BINARY_OP_IC: {

- BinaryOpStub stub(code_object->extended_extra_ic_state());

- description = stub.GetName().Detach();

- tag = Logger::STUB_TAG;

- break;

- }

+ case Code::BINARY_OP_IC:

Hannes Payer (out of office) 2013/12/02 11:39:00 you may wanna add the "// fall through" comment fo

case Code::COMPARE_IC: // fall through

case Code::COMPARE_NIL_IC: // fall through

case Code::TO_BOOLEAN_IC: // fall through

« no previous file with comments | « src/isolate.cc ('k') | src/token.h » ('j') | no next file with comments »