Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: src/isolate.cc

Issue 97543002: Refactor BinaryOpIC to be able to use different stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/log.cc » ('j') | src/log.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2091 matching lines...) Expand 10 before | Expand all | Expand 10 after
2102 StoreBufferOverflowStub::GenerateFixedRegStubsAheadOfTime(this); 2102 StoreBufferOverflowStub::GenerateFixedRegStubsAheadOfTime(this);
2103 StubFailureTrampolineStub::GenerateAheadOfTime(this); 2103 StubFailureTrampolineStub::GenerateAheadOfTime(this);
2104 StubFailureTailCallTrampolineStub::GenerateAheadOfTime(this); 2104 StubFailureTailCallTrampolineStub::GenerateAheadOfTime(this);
2105 // TODO(mstarzinger): The following is an ugly hack to make sure the 2105 // TODO(mstarzinger): The following is an ugly hack to make sure the
2106 // interface descriptor is initialized even when stubs have been 2106 // interface descriptor is initialized even when stubs have been
2107 // deserialized out of the snapshot without the graph builder. 2107 // deserialized out of the snapshot without the graph builder.
2108 FastCloneShallowArrayStub stub(FastCloneShallowArrayStub::CLONE_ELEMENTS, 2108 FastCloneShallowArrayStub stub(FastCloneShallowArrayStub::CLONE_ELEMENTS,
2109 DONT_TRACK_ALLOCATION_SITE, 0); 2109 DONT_TRACK_ALLOCATION_SITE, 0);
2110 stub.InitializeInterfaceDescriptor( 2110 stub.InitializeInterfaceDescriptor(
2111 this, code_stub_interface_descriptor(CodeStub::FastCloneShallowArray)); 2111 this, code_stub_interface_descriptor(CodeStub::FastCloneShallowArray));
2112 BinaryOpStub::InitializeForIsolate(this); 2112 BinaryOpICStub::InstallDescriptors(this);
2113 CompareNilICStub::InitializeForIsolate(this); 2113 CompareNilICStub::InitializeForIsolate(this);
2114 ToBooleanStub::InitializeForIsolate(this); 2114 ToBooleanStub::InitializeForIsolate(this);
2115 ArrayConstructorStubBase::InstallDescriptors(this); 2115 ArrayConstructorStubBase::InstallDescriptors(this);
2116 InternalArrayConstructorStubBase::InstallDescriptors(this); 2116 InternalArrayConstructorStubBase::InstallDescriptors(this);
2117 FastNewClosureStub::InstallDescriptors(this); 2117 FastNewClosureStub::InstallDescriptors(this);
2118 NumberToStringStub::InstallDescriptors(this); 2118 NumberToStringStub::InstallDescriptors(this);
2119 NewStringAddStub::InstallDescriptors(this); 2119 NewStringAddStub::InstallDescriptors(this);
2120 } 2120 }
2121 2121
2122 initialized_from_snapshot_ = (des != NULL); 2122 initialized_from_snapshot_ = (des != NULL);
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
2303 2303
2304 #ifdef DEBUG 2304 #ifdef DEBUG
2305 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2305 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2306 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2306 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2307 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2307 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2308 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2308 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2309 #undef ISOLATE_FIELD_OFFSET 2309 #undef ISOLATE_FIELD_OFFSET
2310 #endif 2310 #endif
2311 2311
2312 } } // namespace v8::internal 2312 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/log.cc » ('j') | src/log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698