Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 97543002: Refactor BinaryOpIC to be able to use different stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2168 matching lines...) Expand 10 before | Expand all | Expand 10 after
2179 } 2179 }
2180 } 2180 }
2181 2181
2182 2182
2183 void LCodeGen::DoArithmeticT(LArithmeticT* instr) { 2183 void LCodeGen::DoArithmeticT(LArithmeticT* instr) {
2184 ASSERT(ToRegister(instr->context()).is(cp)); 2184 ASSERT(ToRegister(instr->context()).is(cp));
2185 ASSERT(ToRegister(instr->left()).is(r1)); 2185 ASSERT(ToRegister(instr->left()).is(r1));
2186 ASSERT(ToRegister(instr->right()).is(r0)); 2186 ASSERT(ToRegister(instr->right()).is(r0));
2187 ASSERT(ToRegister(instr->result()).is(r0)); 2187 ASSERT(ToRegister(instr->result()).is(r0));
2188 2188
2189 BinaryOpStub stub(instr->op(), NO_OVERWRITE); 2189 BinaryOpICStub stub(instr->op(), NO_OVERWRITE);
2190 // Block literal pool emission to ensure nop indicating no inlined smi code 2190 // Block literal pool emission to ensure nop indicating no inlined smi code
2191 // is in the correct position. 2191 // is in the correct position.
2192 Assembler::BlockConstPoolScope block_const_pool(masm()); 2192 Assembler::BlockConstPoolScope block_const_pool(masm());
2193 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 2193 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
2194 __ nop(); // Signals no inlined code. 2194 __ nop(); // Signals no inlined code.
2195 } 2195 }
2196 2196
2197 2197
2198 template<class InstrType> 2198 template<class InstrType>
2199 void LCodeGen::EmitBranch(InstrType instr, Condition condition) { 2199 void LCodeGen::EmitBranch(InstrType instr, Condition condition) {
(...skipping 3675 matching lines...) Expand 10 before | Expand all | Expand 10 after
5875 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5875 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5876 __ ldr(result, FieldMemOperand(scratch, 5876 __ ldr(result, FieldMemOperand(scratch,
5877 FixedArray::kHeaderSize - kPointerSize)); 5877 FixedArray::kHeaderSize - kPointerSize));
5878 __ bind(&done); 5878 __ bind(&done);
5879 } 5879 }
5880 5880
5881 5881
5882 #undef __ 5882 #undef __
5883 5883
5884 } } // namespace v8::internal 5884 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/code-stubs.h » ('j') | src/log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698