mojo/common: Decouple GURL dependency

mojo/common: Decouple GURL dependency

This prevents mojo/common from having win64 build.
This CL move it to its own static library so that
environment component doesn't depend on it.

BUG=377980
R=jamesr@chromium.org, rockot@chromium.org
TBR=jrummell@chromium.org, eroman@chromium.org

Committed: https://crrev.com/9e8f56a35b8b6dab5d86e21fff04c9f4ca437cc3
Cr-Commit-Position: refs/heads/master@{#319314}

[jamesr, 2015-03-03 21:29:05]

What about this doesn't work on win64?

[jamesr, 2015-03-03 21:30:11]

As the trybot runs show this converter is being used by the network service, at
least.

[Hajime Morrita, 2015-03-03 21:36:11]

On 2015/03/03 21:30:11, jamesr wrote:
> As the trybot runs show this converter is being used by the network service,
at
> least.

Oops. I should've built chrome, not only content_shell.
GURL has a dependency to ICU and I hoped to avoid building the win64 variant of
that.

[jamesr, 2015-03-03 21:46:02]

You should build the network service.

A lot of stuff depends on ICU - how does that build on win64?

[Hajime Morrita, 2015-03-03 21:51:42]

On 2015/03/03 21:46:02, jamesr wrote:
> A lot of stuff depends on ICU - how does that build on win64?

Oh, I was talking about win64 build on win32 configuration.
Chrome win32 build does have some win64 bits for building NaCL launcher
executable,
which has to be built as both win32 and win64 even for win32 chrome.
Its dependencies have to have win64-in-win32 configuration as well.
This makes things complicated.

[jamesr, 2015-03-03 21:59:00]

If this particular converter is annoying you can move it to a separate converter
target, but be sure to update users of it as well.

[Ken Rockot(use gerrit already), 2015-03-04 03:27:56]

lgtm but I think there are extraneous includes and dependencies now (marked some
inline), as the URL type converters may have been the only parts of mojo/common
used in some places.

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/co...
File mojo/services/network/cookie_store_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/co...
mojo/services/network/cookie_store_impl.cc:7: #include
"mojo/common/common_type_converters.h"
same question

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/ur...
File mojo/services/network/url_loader_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/ur...
mojo/services/network/url_loader_impl.cc:9: #include
"mojo/common/common_type_converters.h"
Is this header still needed?

https://codereview.chromium.org/975083002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/975083002/diff/40001/net/net.gyp#newcode1298
net/net.gyp:1298: '../mojo/mojo_base.gyp:mojo_common_lib',
Is this dependency still needed?

https://codereview.chromium.org/975083002/diff/40001/net/proxy/mojo_proxy_res...
File net/proxy/mojo_proxy_resolver_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/net/proxy/mojo_proxy_res...
net/proxy/mojo_proxy_resolver_impl.cc:8: #include
"mojo/common/common_type_converters.h"
Is this header still needed?

[jamesr, 2015-03-04 04:14:44]

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (left):

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#old...
mojo/common/BUILD.gn:47: "//url",
the test still appears to test url conversions - why is the dep removed? does
this pass gn check?

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#new...
mojo/common/BUILD.gn:41: static_library("url_type_converters") {
source_set

static_library is extremely rarely what you want in GN

document the name of the gyp equivalent

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#new...
mojo/common/BUILD.gn:50:
"//third_party/mojo/src/mojo/public/c/system:for_component",
this is not a component so this is the wrong target to depend on

[Hajime Morrita, 2015-03-05 18:29:41]

PTAL?

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (left):

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#old...
mojo/common/BUILD.gn:47: "//url",
On 2015/03/04 04:14:44, jamesr wrote:
> the test still appears to test url conversions - why is the dep removed? does
> this pass gn check?
Got it back and gn check passes now.

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#new...
mojo/common/BUILD.gn:41: static_library("url_type_converters") {
On 2015/03/04 04:14:44, jamesr wrote:
> source_set
> 
> static_library is extremely rarely what you want in GN
> 
> document the name of the gyp equivalent

Done.

https://codereview.chromium.org/975083002/diff/40001/mojo/common/BUILD.gn#new...
mojo/common/BUILD.gn:50:
"//third_party/mojo/src/mojo/public/c/system:for_component",
On 2015/03/04 04:14:44, jamesr wrote:
> this is not a component so this is the wrong target to depend on

Done.

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/co...
File mojo/services/network/cookie_store_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/co...
mojo/services/network/cookie_store_impl.cc:7: #include
"mojo/common/common_type_converters.h"
On 2015/03/04 03:27:56, Ken Rockot wrote:
> same question

Done.

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/ur...
File mojo/services/network/url_loader_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/mojo/services/network/ur...
mojo/services/network/url_loader_impl.cc:9: #include
"mojo/common/common_type_converters.h"
On 2015/03/04 03:27:56, Ken Rockot wrote:
> Is this header still needed?

Done.

https://codereview.chromium.org/975083002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/975083002/diff/40001/net/net.gyp#newcode1298
net/net.gyp:1298: '../mojo/mojo_base.gyp:mojo_common_lib',
On 2015/03/04 03:27:56, Ken Rockot wrote:
> Is this dependency still needed?

Done.

https://codereview.chromium.org/975083002/diff/40001/net/proxy/mojo_proxy_res...
File net/proxy/mojo_proxy_resolver_impl.cc (right):

https://codereview.chromium.org/975083002/diff/40001/net/proxy/mojo_proxy_res...
net/proxy/mojo_proxy_resolver_impl.cc:8: #include
"mojo/common/common_type_converters.h"
On 2015/03/04 03:27:56, Ken Rockot wrote:
> Is this header still needed?

Done.

[jamesr, 2015-03-05 18:33:23]

lgtm

https://codereview.chromium.org/975083002/diff/80001/mojo/common/BUILD.gn
File mojo/common/BUILD.gn (right):

https://codereview.chromium.org/975083002/diff/80001/mojo/common/BUILD.gn#new...
mojo/common/BUILD.gn:48: include_dirs = [ "../../third_party/mojo/src/" ]
write this as

//third_party/mojo/src/

all deps in chromium files should be absolute to the root, just like #includes

[Hajime Morrita, 2015-03-05 19:24:36]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2015-03-05 19:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jamesr@chromium.org
Link to the patchset: https://codereview.chromium.org/975083002/#ps100001
(title: "Landing")

[commit-bot: I haz the power, 2015-03-05 19:25:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975083002/100001

[commit-bot: I haz the power, 2015-03-05 20:30:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-05 20:31:20]

Patchset 6 (id:??) landed as
https://crrev.com/9e8f56a35b8b6dab5d86e21fff04c9f4ca437cc3
Cr-Commit-Position: refs/heads/master@{#319314}