mojo/common: Decouple GURL dependency

mojo/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 
+group("common") {
+  deps = [
+    ":common_base",
+    ":url_type_converters",
+  ]
+}
+
 # GYP version: mojo/mojo_base.gyp:mojo_common_lib
-component("common") {
+component("common_base") {
   output_name = "mojo_common_lib"
 
   sources = [
     "common_type_converters.cc",
     "common_type_converters.h",
     "data_pipe_utils.cc",
     "data_pipe_utils.h",
     "handle_watcher.cc",
     "handle_watcher.h",
     "message_pump_mojo.cc",
     "message_pump_mojo.h",
     "message_pump_mojo_handler.h",
     "time_helper.cc",
     "time_helper.h",
   ]
 
   defines = [ "MOJO_COMMON_IMPLEMENTATION" ]
 
   deps = [
     "//base",
     "//base/third_party/dynamic_annotations",
     "//third_party/mojo/src/mojo/public/c/system:for_component",
+  ]
+}
+
+static_library("url_type_converters") {

[jamesr, 2015/03/04 04:14:44]

source_set

static_library is extremely rarely what you want in GN

document the name of the gyp equivalent

[Hajime Morrita, 2015/03/05 18:29:41]

Done.

+  sources = [
+    "url_type_converters.cc",
+    "url_type_converters.h",
+  ]
+
+  deps = [
+    "//base",
+    "//base/third_party/dynamic_annotations",
+    "//third_party/mojo/src/mojo/public/c/system:for_component",

[jamesr, 2015/03/04 04:14:44]

this is not a component so this is the wrong target to depend on

[Hajime Morrita, 2015/03/05 18:29:41]

Done.

     "//url",
   ]
 }
 
 # GYP version: mojo/mojo_base.gyp:mojo_common_unittests
 test("mojo_common_unittests") {
   deps = [
     ":common",
     "//base",
     "//base:message_loop_tests",
     "//mojo/environment:chromium",
     "//testing/gtest",
     "//third_party/mojo/src/mojo/edk/test:run_all_unittests",
     "//third_party/mojo/src/mojo/edk/test:test_support",
     "//third_party/mojo/src/mojo/public/cpp/bindings",
     "//third_party/mojo/src/mojo/public/cpp/test_support:test_utils",
-    "//url",

[jamesr, 2015/03/04 04:14:44]

the test still appears to test url conversions - why is the dep removed? does
this pass gn check?

[Hajime Morrita, 2015/03/05 18:29:41]

Got it back and gn check passes now.

   ]
 
   sources = [
     "common_type_converters_unittest.cc",
     "handle_watcher_unittest.cc",
     "message_pump_mojo_unittest.cc",
   ]
 }