mojo/common: Decouple GURL dependency

mojo/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 
+group("common") {
+  deps = [
+    ":common_base",
+    ":url_type_converters",
+  ]
+}
+
 # GYP version: mojo/mojo_base.gyp:mojo_common_lib
-component("common") {
+component("common_base") {
   output_name = "mojo_common_lib"
 
   sources = [
     "common_type_converters.cc",
     "common_type_converters.h",
     "data_pipe_utils.cc",
     "data_pipe_utils.h",
     "handle_watcher.cc",
     "handle_watcher.h",
     "message_pump_mojo.cc",
     "message_pump_mojo.h",
     "message_pump_mojo_handler.h",
     "time_helper.cc",
     "time_helper.h",
   ]
 
   defines = [ "MOJO_COMMON_IMPLEMENTATION" ]
 
   deps = [
     "//base",
     "//base/third_party/dynamic_annotations",
     "//third_party/mojo/src/mojo/public/c/system:for_component",
+  ]
+}
+
+# GYP version: mojo/mojo_base.gyp:mojo_url_type_converters
+source_set("url_type_converters") {
+  sources = [
+    "url_type_converters.cc",
+    "url_type_converters.h",
+  ]
+
+  include_dirs = [ "../../third_party/mojo/src/" ]

[jamesr, 2015/03/05 18:33:22]

write this as

//third_party/mojo/src/

all deps in chromium files should be absolute to the root, just like #includes

+
+  deps = [
+    ":common_base",
+    "//base",
+    "//base/third_party/dynamic_annotations",
     "//url",
   ]
 }
 
 # GYP version: mojo/mojo_base.gyp:mojo_common_unittests
 test("mojo_common_unittests") {
   deps = [
     ":common",
     "//base",
     "//base:message_loop_tests",
     "//mojo/environment:chromium",
     "//testing/gtest",
     "//third_party/mojo/src/mojo/edk/test:run_all_unittests",
     "//third_party/mojo/src/mojo/edk/test:test_support",
     "//third_party/mojo/src/mojo/public/cpp/bindings",
     "//third_party/mojo/src/mojo/public/cpp/test_support:test_utils",
     "//url",
   ]
 
   sources = [
     "common_type_converters_unittest.cc",
     "handle_watcher_unittest.cc",
     "message_pump_mojo_unittest.cc",
   ]
 }