Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: mojo/mojo_base.gyp

Issue 975083002: mojo/common: Decouple GURL dependency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Landing Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/environment/BUILD.gn ('k') | mojo/services/html_viewer/weburlloader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojo_base.gyp
diff --git a/mojo/mojo_base.gyp b/mojo/mojo_base.gyp
index c0d4bac6b518fc7a568b495ca1ade1cdff4434ba..9f73e5de8e013239c143786866a5ee9e873a1142 100644
--- a/mojo/mojo_base.gyp
+++ b/mojo/mojo_base.gyp
@@ -44,7 +44,6 @@
],
'dependencies': [
'../base/base.gyp:base',
- '../url/url.gyp:url_lib',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'<(mojo_system_for_component)',
],
@@ -66,6 +65,24 @@
],
},
{
+ # GN version: //mojo/common:url_type_converters
+ 'target_name': 'mojo_url_type_converters',
+ 'type': 'static_library',
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ '../url/url.gyp:url_lib',
+ '<(mojo_system_for_component)',
+ ],
+ 'export_dependent_settings': [
+ '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+ ],
+ 'sources': [
+ 'common/url_type_converters.cc',
+ 'common/url_type_converters.h',
+ ],
+ },
+ {
# GN version: //mojo/common:mojo_common_unittests
'target_name': 'mojo_common_unittests',
'type': 'executable',
@@ -76,6 +93,7 @@
'../testing/gtest.gyp:gtest',
'../url/url.gyp:url_lib',
'mojo_common_lib',
+ 'mojo_url_type_converters',
'../third_party/mojo/mojo_edk.gyp:mojo_system_impl',
'../third_party/mojo/mojo_edk.gyp:mojo_common_test_support',
'../third_party/mojo/mojo_edk.gyp:mojo_run_all_unittests',
« no previous file with comments | « mojo/environment/BUILD.gn ('k') | mojo/services/html_viewer/weburlloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698